Skip changelog generation if there is nothing to be viewed#2461
Merged
christianlupus merged 3 commits intomasterfrom Aug 25, 2024
Merged
Skip changelog generation if there is nothing to be viewed#2461christianlupus merged 3 commits intomasterfrom
christianlupus merged 3 commits intomasterfrom
Conversation
Signed-off-by: Christian Wolf <github@christianwolf.email>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2461 +/- ##
==========================================
+ Coverage 78.51% 78.55% +0.04%
==========================================
Files 95 95
Lines 2755 2761 +6
==========================================
+ Hits 2163 2169 +6
Misses 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 12 files 584 suites 1m 32s ⏱️ Results for commit abe56b3. ♻️ This comment has been updated with latest results. |
Signed-off-by: Christian Wolf <github@christianwolf.email>
abe56b3 to
d8e1945
Compare
Signed-off-by: Christian Wolf <github@christianwolf.email>
Collaborator
Author
|
/approve |
nextcloud-cookbook-bot
approved these changes
Aug 25, 2024
Collaborator
nextcloud-cookbook-bot
left a comment
There was a problem hiding this comment.
Automatically approved by GitHub action on behalf of /approve
Collaborator
Author
|
/backport to main-0.10.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Currently, the automerge of the dependabot fails. Dependabot does not create changelog stubs. Although this is generally okay for some files to change without explicit changelog, the generation of the GitHub step summary in the actions tab involves so far a generation of the total Changelog. This fails if there is no matching changelog present.
Concerns/issues
Should be save to merge, as in the workflow, either the error no changelog found is triggered of the python script is run.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.